Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trip survey forward URL #280

Merged
merged 7 commits into from
Dec 17, 2024
Merged

Trip survey forward URL #280

merged 7 commits into from
Dec 17, 2024

Conversation

binh-dam-ibigroup
Copy link
Collaborator

@binh-dam-ibigroup binh-dam-ibigroup commented Dec 13, 2024

Checklist

  • Appropriate branch selected (all PRs must first be merged to dev before they can be merged to master)
  • Any modified or new methods or classes have helpful JavaDoc and code is thoroughly commented
  • [na] The description lists all applicable issues this PR seeks to resolve
  • [na] The description lists any configuration setting(s) that differ from the default settings
  • All tests and CI builds passing

Description

This PR adds an endpoint that forwards to the post-travel survey. The endpoint is intended for use after tapping a corresponding push notification and will log the opened date of the push notification.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wish our version of MongoDB would work with the java.time.* classes rather than java.util.Date, but apparently that can't be helped.

Copy link
Contributor

@JymDyerIBI JymDyerIBI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me.

Copy link
Contributor

@br648 br648 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of minor nits. Apart from them, all good.

@@ -129,6 +130,7 @@ private static void initializeHttpEndpoints() throws IOException {
new LogController(API_PREFIX),
new ErrorEventsController(API_PREFIX),
new CDPFilesController(API_PREFIX),
new TripSurveyController(API_PREFIX),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit. Shame these aren't ordered alphabetically.

@Override
public void bind(final SparkSwagger restApi) {
restApi.endpoint(
endpointPath(ROOT_ROUTE).withDescription("Interface for tracking opened trip surveys following a trip survey notification"),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit. Full stop.

@br648 br648 assigned binh-dam-ibigroup and unassigned br648 Dec 17, 2024
@binh-dam-ibigroup binh-dam-ibigroup merged commit 7d6134f into dev Dec 17, 2024
2 checks passed
@binh-dam-ibigroup binh-dam-ibigroup deleted the trip-survey-forward-url branch December 17, 2024 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants